[Trivial] Add test-ios command to package.json#24985
Closed
hramos wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
react-native-bot
added
Platform: iOS
hramos
force-pushed
the
add-ios-test-script
branch
from
f1a7fb1 to
f545d1f
Compare
facebook-github-bot
approved these changes
May 22, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @hramos in 45b5e5f. When will my fix make it into a release? | Upcoming Releases |
vovkasm
pushed a commit
to vovkasm/react-native
that referenced
this pull request
Aug 12, 2019
Summary: There is currently no entry point for running the RNTester tests in package.json. This adds a test-ios command which leverages the existing objc-test-ios.sh script. With this change in place, our documentation for running tests locally can be simplified and made consistent with how JavaScript tests are run (yarn test). ## Changelog [General] [Added] - Add a test-ios command to run iOS RNTester tests locally Pull Request resolved: facebook#24985 Differential Revision: D15449399 Pulled By: cpojer fbshipit-source-id: 63f7ad653d23c5601a11fc9d27a39b4987fccaad (cherry picked from commit 45b5e5f)
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: There is currently no entry point for running the RNTester tests in package.json. This adds a test-ios command which leverages the existing objc-test-ios.sh script. With this change in place, our documentation for running tests locally can be simplified and made consistent with how JavaScript tests are run (yarn test). ## Changelog [General] [Added] - Add a test-ios command to run iOS RNTester tests locally Pull Request resolved: facebook#24985 Differential Revision: D15449399 Pulled By: cpojer fbshipit-source-id: 63f7ad653d23c5601a11fc9d27a39b4987fccaad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There is currently no entry point for running the RNTester tests in package.json. This adds a test-ios command which leverages the existing objc-test-ios.sh script.
With this change in place, our documentation for running tests locally can be simplified and made consistent with how JavaScript tests are run (yarn test).
Changelog
[General] [Added] - Add a test-ios command to run iOS RNTester tests locally
Test Plan
yarn test-iosinvokes the objc-test-ios.sh script.Future work
The rest of the commands here should be cleaned up, but that's a non-goal for this pull request. In the future, I could see us having separate test-ios-unit and test-ios-integration commands, to match the existing Android docker commands.